Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't retry on 409 status #47

Merged
merged 4 commits into from
Nov 19, 2024
Merged

don't retry on 409 status #47

merged 4 commits into from
Nov 19, 2024

Conversation

csillasch
Copy link
Contributor

Terminates the request on status code 409 (eg. selecting columns that don`t exist) instead of retrying.

@csillasch csillasch requested a review from Moohan November 14, 2024 17:35
@Moohan
Copy link
Member

Moohan commented Nov 14, 2024

Should we add a test i.e. something that returns a 409, and test for no messages? https://testthat.r-lib.org/reference/expect_silent.html

@Moohan Moohan changed the title don`t retry on 409 status don't retry on 409 status Nov 14, 2024
Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Moohan Moohan merged commit 759e371 into master Nov 19, 2024
1 check passed
@csillasch csillasch deleted the edit-httr-retry branch November 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants